From: Christian Korber <ckorber@tdt.de>
Date: Mon, 29 Jul 2024 08:45:11 +0000 (+0200)
Subject: luci-app-snmpd: add SNMPv1/v2c tab
X-Git-Url: http://git.openwrt.org/%22https:/collectd.org//%22http:/www.crowdsec.net/%22/%22https:/collectd.org/%22http:/www.crowdsec.net/%22?a=commitdiff_plain;h=6bb877635156b81c9011781758e592fa89ddfb9e;p=project%2Fluci.git

luci-app-snmpd: add SNMPv1/v2c tab

This commit adds commonities for SNMPv1 and v2c.
It is possible to implement communities by default, via hostname
or with IP/BITS.

Signed-off-by: Christian Korber <ckorber@tdt.de>
---

diff --git a/applications/luci-app-snmpd/htdocs/luci-static/resources/view/snmpd/snmpd.js b/applications/luci-app-snmpd/htdocs/luci-static/resources/view/snmpd/snmpd.js
index 5aaebdc4c2..cc6c9492dc 100644
--- a/applications/luci-app-snmpd/htdocs/luci-static/resources/view/snmpd/snmpd.js
+++ b/applications/luci-app-snmpd/htdocs/luci-static/resources/view/snmpd/snmpd.js
@@ -18,6 +18,11 @@ return L.view.extend({
 	__init__: function() {
 		this.super('__init__', arguments);
 
+		this.ro_community = null;
+		this.ro_community_src = null;
+		this.rw_community = null;
+		this.rw_community_src = null;
+		this.oid = null;
 		this.ip_protocol = null;
 		this.snmp_version = null;
 	},
@@ -69,6 +74,84 @@ return L.view.extend({
 		go.remove = snmpd_sys_remove;
 	},
 
+	populateV1V2CSettings: function(subsection, desc, access, s) {
+		let g, go, o, community, community_src, mode, mask;
+
+		o = s.taboption('v1/v2c', form.SectionValue, '__v1/v2c__',
+			form.GridSection, subsection, null, desc);
+
+		g = o.subsection;
+		g.anonymous = true;
+		g.addremove = true;
+		g.nodescriptions = true;
+		g.modaltitle = desc;
+
+		go = g.option(form.ListValue, 'Mode', _('Access Control'),
+			_('Access restriction to readonly or Read/Write'));
+		go.value('rwcommunity', _('Read/Write'));
+		go.value('rocommunity', _('Readonly'));
+
+		community = g.option(form.Value, 'CommunityName',
+			_('Community Name'),
+			_('Community that is used for SNMP'));
+		community.datatype = 'string';
+		community.default = '';
+		community.optional = false;
+		community.rmempty = false;
+		if(access == null) {
+			if (uci.get('snmpd', 'access_default', 'Mode') === 'rwcommunity') {
+				this.rw_community_src = 'default';
+			} else {
+				this.ro_community_src = 'default';
+			}
+		}
+
+		if (access !== null) {
+			community_src = g.option(form.Value, access,
+				_('Community source'),
+				_('Trusted source for SNMP read community access (hostname or IP)'));
+			community_src.value('default', _('any (default)'));
+			community_src.value('localhost', _('localhost'));
+			community_src.default = 'default';
+			community_src.optional = false;
+			community_src.rmempty = false;
+			community_src.datatype = 'host(0)';
+
+			if (access == 'HostIP') {
+				mask = g.option(form.Value, 'IPMask',
+					_('IPMask'),
+					_('Prefix'));
+				mask.rmempty = false;
+				mask.datatype = 'and(ip6prefix, ip4prefix)';
+				mask.size = 2;
+			}
+		}
+
+		go = g.option(form.ListValue, 'RestrictOID',
+			_('OID-Restriction'),
+			_('Restriction to specific OID'));
+		go.value('no', _('No'));
+		go.value('yes', _('Yes'));
+		go.default = 'no';
+		go.optional = false;
+		go.rmempty = false;
+
+		this.oid = g.option(form.Value,
+			'RestrictedOID',
+			_('OID'),
+			_('Restrict to the following OID node/branch'));
+		this.oid.datatype = 'string';
+		this.oid.depends('RestrictOID', 'yes');
+
+		if (go === 'rocommunity') {
+			this.ro_community = community;
+			this.ro_community_src = community_src;
+		} else {
+			this.rw_community = community;
+			this.rw_community_src = community_src;
+		}
+	},
+
 	render: function(data) {
 		let m, s, o, g, go;
 
@@ -205,6 +288,14 @@ return L.view.extend({
 		go.modalonly = true;
 		go.optional = false;
 
+		s.tab('v1/v2c', _('SNMPv1/SNMPv2c'));
+		this.populateV1V2CSettings('access_default',
+			_('Communities for any hosts'), null, s);
+		this.populateV1V2CSettings('access_HostName',
+			_('Communities via hostname'), 'HostName', s);
+		this.populateV1V2CSettings('access_HostIP',
+			_('Communities via IP-Address range'), 'HostIP', s);
+
 		return m.render();
 	},